[fix] WMS layer fixes 2 - #3149
Merged
Merged
Conversation
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds experimental WMS layer support across configuration, data loading, constants, core layers, and UI.
- Introduces a new
WMSDatasetMetadatatype, refresh logic (refreshWMSMetadata), and loader (getWMSCapabilities). - Adds a
WMSLayerimplementation in both Kepler.gl layers and Deck.gl composite layers. - Updates application config, constants, and UI components (icons, forms, panels) to integrate WMS settings.
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/src/application-config.ts | Relocated and re-ordered enableWMSLayer flag |
| src/table/src/dataset-utils.ts | Added refreshWMSMetadata and WMS capabilities loader |
| src/constants/src/dataset.ts | Defined new WMSDatasetMetadata type |
| src/constants/src/layers.ts | Removed WMS from editor-available layers |
| src/layers/src/wms-layer/wms-layer.ts | Updated core WMS layer implementation |
| src/layers/src/wms-layer/wms-layer-icon.tsx | Replaced icon SVG paths |
| src/deckgl-layers/src/wms/wms-layer.ts | Added Deck.gl composite WMS layer copy |
Comments suppressed due to low confidence (3)
src/table/src/dataset-utils.ts:259
- The parameter name
wsmUrlappears to be a typo; consider renaming it towmsUrlfor consistency.
export async function getWMSCapabilities(wsmUrl: string): Promise<WMSCapabilities> {
src/constants/src/layers.ts:567
- Removing
LAYER_TYPES.wmsfromEDITOR_AVAILABLE_LAYERSwill hide the WMS layer option in the editor. Confirm if this removal is intentional.
LAYER_TYPES.geojson
src/table/src/dataset-utils.ts:242
- [nitpick] Consider adding unit tests for
refreshWMSMetadataandwmsCapabilitiesToDatasetMetadatato validate WMS metadata parsing and error handling.
async function refreshWMSMetadata(datasetInfo: CreateTableProps): Promise<any | null> {
…ler.gl into igr/wms-layer-fixes
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
ilyabo
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.